Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release 1.17.1 #1677

Merged
merged 1 commit into from
Mar 22, 2023
Merged

chore: release 1.17.1 #1677

merged 1 commit into from
Mar 22, 2023

Conversation

jmayclin
Copy link
Contributor

Description of changes:

updates s2n-quic to 1.17.1

Call-outs:

1.17.0 was not released. I don't expect there to be any particular complications with that, but please comment if you see some issue with that.

Testing:

CI should pass

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmayclin jmayclin requested a review from toidiu March 22, 2023 19:00
@jmayclin jmayclin marked this pull request as ready for review March 22, 2023 19:00
version = "0.18.0"
version = "0.18.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these are unstable crates anyway should we just bump the minor version? In the next release we would be bumping to 0.19.0 anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of trying to stick to semver for all of the crates, because I think that's easier to reason about.

E.g. "we follow semver for all of the crates that we publish" rather than "we follow semver for the primary crate that we publish and but not for published, non-primary crates"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I admit that figuring out whether things should be minor/patch bumps is currently rather tedious, the solution I would push for is automating version bumps through the conventional commit parsing.

@jmayclin jmayclin merged commit a6c8fbe into aws:main Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants